Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix after value-function #1388

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix prefix after value-function #1388

wants to merge 2 commits into from

Conversation

vlazh
Copy link

@vlazh vlazh commented Aug 31, 2020

Prefixing of value-function is not worked. So it fix it. But I'm not sure if I did it right.

Prefixing of value-function is not worked. So it fix it. But I'm not sure if I did it right.
@vlazh vlazh requested a review from HenriBeck as a code owner August 31, 2020 15:28
@vlazh
Copy link
Author

vlazh commented Sep 1, 2020

It seems like CI errors, not code.

@kof
Copy link
Member

kof commented Oct 12, 2020

Thanks for the PR, looks correct but I can't merge it unless we add a test!

@kof kof added the needs tests We can't merge a change without tests verifying it's behaviour label Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests We can't merge a change without tests verifying it's behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants